support for Loggers#95
Closed
llllllllll wants to merge 1 commit into
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
==========================================
+ Coverage 79.88% 80.03% +0.15%
==========================================
Files 2 2
Lines 522 526 +4
Branches 109 109
==========================================
+ Hits 417 421 +4
Misses 75 75
Partials 30 30
Continue to review full report at Codecov.
|
Member
|
Oops, I pushed another PR in #96. |
Member
|
Since this one is passing and first currently, I lean towards merging this one. Y'all got this though. |
Member
|
PR #96 has more thorough tests, though. I'll fix the failing test on 2.6. |
Contributor
Author
|
Closing in favor of #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #94
Interestingly, this worked on PyPy without my change but it produced a very large serialized form.